daniel has posted comments on this change. ( https://gerrit.osmocom.org/10166 )
Change subject: msc: Fix random error of TC_cl3_rnd_payload ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1158 PS1, Line 1158: // length is limited by PDU_BSSAP length field which includes some > Better use /* */ for comments. Done https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1159 PS1, Line 1159: // other fields beside l3info payload. So payl can only be 240 bytes > be "max" 240 bytes? […] The short answer was that before it was 256 for a max length of 255. The long answer is that rnd() always returns a value < 1 and float2int does not round. In https://www.etsi.org/deliver/etsi_es/201800_201899/20187301/04.10.01_60/es_20187301v041001p.pdf#page=343 the formula for generating values in a given range is: float2int(int2float(upperbound - lowerbound +1)*rnd()) + lowerbound // with lowerbound 0, upperbound 240 https://gerrit.osmocom.org/#/c/10166/1/msc/MSC_Tests.ttcn@1162 PS1, Line 1162: log("Length:", len); > We can drop this line. Thanks, forgot this one -- To view, visit https://gerrit.osmocom.org/10166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be33e261a11f03a80a6b770b6acf0a4be49b85b Gerrit-Change-Number: 10166 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 09:29:20 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
