Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10174 )
Change subject: fix strncpy bugs in gsm/ipa.c ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/10174/1/src/gsm/ipa.c File src/gsm/ipa.c: https://gerrit.osmocom.org/#/c/10174/1/src/gsm/ipa.c@270 PS1, Line 270: snprintf(str, sizeof(str), "%s", dev->unit_name); Why not passing dev->unit_name directly instead? Looks like this line previous commit was wrong hree passing IPA_STRING_MAX right? -- To view, visit https://gerrit.osmocom.org/10174 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I423a24c55c9b9aa6fc8f501df94fe54c71ee2b2b Gerrit-Change-Number: 10174 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 26 Jul 2018 15:39:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
