Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10185 )
Change subject: port arfcn range encode support from osmo-bsc ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/10185/2/include/osmocom/gsm/gsm48_arfcn_range_encode.h File include/osmocom/gsm/gsm48_arfcn_range_encode.h: https://gerrit.osmocom.org/#/c/10185/2/include/osmocom/gsm/gsm48_arfcn_range_encode.h@17 PS2, Line 17: int gsm48_range_enc_determine_range(const int *arfcns, int size, int *f0_out); for newly-introduced symbols we typically use an "osmo_" prefix. non "osmo_" prefixed symbols are all legacy. Yes, the symbol names get a bit long with all those prefixes, but the general rule is that applications must not define symbols with osmo_ prefix, while the libraries provide symbols with osmo_ prefix. -- To view, visit https://gerrit.osmocom.org/10185 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia220764fba451be5e975ae7c5eefb1a25ac2bf2c Gerrit-Change-Number: 10185 Gerrit-PatchSet: 2 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Fri, 27 Jul 2018 13:08:44 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
