Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10213 )
Change subject: sniff: increase debug output ...................................................................... Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10213/2/firmware/libcommon/source/sniffer.c File firmware/libcommon/source/sniffer.c: https://gerrit.osmocom.org/#/c/10213/2/firmware/libcommon/source/sniffer.c@302 PS2, Line 302: don't print since this is function is also called by ISRs is the function now no longer called by ISRs? If not, then remove the comment. If it's still called from ISRs, enabling debug will likely create timing problems :/ -- To view, visit https://gerrit.osmocom.org/10213 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife0bbcf4a25aaa445a36768c00004e6e0d9a4947 Gerrit-Change-Number: 10213 Gerrit-PatchSet: 2 Gerrit-Owner: Kévin Redon <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 28 Jul 2018 21:21:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
