Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10218 )
Change subject: remsim: add msg payload after header ...................................................................... Patch Set 2: Code-Review-1 I don't think this is the right solution, sorry. Message buffers exist exactly to avoid ever copying data around, but to have a flexible buffer to which data can be pre-pended (pushed) and appended (put) at any point in time. If the old code was overwriting something, the msgb must have been in a bad state or there's some other bug in the code using msgb's. I don't understand why we'd want to alloacate a new one and copy data over? -- To view, visit https://gerrit.osmocom.org/10218 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If971699993617fc50557d20582c344ea06645a3f Gerrit-Change-Number: 10218 Gerrit-PatchSet: 2 Gerrit-Owner: Kévin Redon <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Comment-Date: Sun, 29 Jul 2018 08:12:47 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
