Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10323 )
Change subject: hlr_ussd.c: avoid using CR and NL in IUSE responses ...................................................................... Patch Set 1: > I actually intentionally added the \n in OsmoHLR as we also had the > \n in OsmoMSC before, and I wanted to make sure the messages are > identical in both cases, not to break tests e.g. in > osmo-gsm-tester. AFAIR, we had exactly '\r' in OsmoMSC (and still have in OpenBSC). At least, it makes sense to replace '\n' by '\r'... -- To view, visit https://gerrit.osmocom.org/10323 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I09e8a67758698f3b7a578eab956311e269d091ee Gerrit-Change-Number: 10323 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 02 Aug 2018 19:41:06 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
