Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/10325


Change subject: gsm/gsm0480.c: prevent NULL-pointer dereference
......................................................................

gsm/gsm0480.c: prevent NULL-pointer dereference

Change-Id: I444d95941837458b46e581298f76f3a9926c8552
---
M src/gsm/gsm0480.c
1 file changed, 10 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/10325/1

diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 2d2df4a..5b51c75 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -880,7 +880,11 @@
  */
 struct msgb *gsm0480_gen_return_error(uint8_t invoke_id, uint8_t error_code)
 {
-       struct msgb *msg = gsm0480_msgb_alloc_name("TS 04.80 ReturnError");
+       struct msgb *msg;
+
+       msg = gsm0480_msgb_alloc_name("TS 04.80 ReturnError");
+       if (!msg)
+               return NULL;

        /* First insert the problem code */
        msgb_push_TLV1(msg, GSM_0480_ERROR_CODE_TAG, error_code);
@@ -906,7 +910,11 @@
  */
 struct msgb *gsm0480_gen_reject(int invoke_id, uint8_t problem_tag, uint8_t 
problem_code)
 {
-       struct msgb *msg = gsm0480_msgb_alloc_name("TS 04.80 Reject");
+       struct msgb *msg;
+
+       msg = gsm0480_msgb_alloc_name("TS 04.80 Reject");
+       if (!msg)
+               return NULL;

        /* First insert the problem code */
        msgb_push_TLV1(msg, problem_tag, problem_code);

--
To view, visit https://gerrit.osmocom.org/10325
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I444d95941837458b46e581298f76f3a9926c8552
Gerrit-Change-Number: 10325
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>

Reply via email to