Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/10332 )
Change subject: vty/vty.c: fix bug in vty_config_write
......................................................................
vty/vty.c: fix bug in vty_config_write
the vty_config_write function should write:
line vty
login
to the configuration file when the login is enabled. Otherwise after
saving the configuration the next login will be performed without
password checking (password_check variable will be 0 though it must be 1)
Change-Id: I39050b6bf617dac10d3fccc3106f67bdcca1d05a
---
M src/vty/vty.c
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Vadim Yanitskiy: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/vty/vty.c b/src/vty/vty.c
index aab0607..ad53537 100644
--- a/src/vty/vty.c
+++ b/src/vty/vty.c
@@ -1694,6 +1694,8 @@
/* login */
if (!password_check)
vty_out(vty, " no login%s", VTY_NEWLINE);
+ else
+ vty_out(vty, " login%s", VTY_NEWLINE);
/* bind */
if (vty_bind_addr && (strcmp(vty_bind_addr, VTY_BIND_ADDR_DEFAULT) !=
0))
--
To view, visit https://gerrit.osmocom.org/10332
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I39050b6bf617dac10d3fccc3106f67bdcca1d05a
Gerrit-Change-Number: 10332
Gerrit-PatchSet: 2
Gerrit-Owner: Mykola Shchetinin <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
