Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10326 )
Change subject: gsm/gsm0480.c: use the local msgb allocator ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10326/1/src/gsm/gsm0480.c File src/gsm/gsm0480.c: https://gerrit.osmocom.org/#/c/10326/1/src/gsm/gsm0480.c@128 PS1, Line 128: s as this is a public, non-static symbol, there's no need to move the function from bottom to top. Let's not introduce unneeded changes, thanks. -- To view, visit https://gerrit.osmocom.org/10326 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23b4b0e1c237b9b27c1db1c9a824b5329d41a38b Gerrit-Change-Number: 10326 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 05 Aug 2018 07:11:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
