daniel has posted comments on this change. ( https://gerrit.osmocom.org/10343 )
Change subject: osmocom-nightly-packages: Ensure PACKAGE_VERSION is set correctly ...................................................................... Patch Set 1: Code-Review-1 (2 comments) This seems to break the get_commit_version() function which will never return the git version, but only the one from debian/changelog https://gerrit.osmocom.org/#/c/10343/1/scripts/osmocom-nightly-packages.sh File scripts/osmocom-nightly-packages.sh: https://gerrit.osmocom.org/#/c/10343/1/scripts/osmocom-nightly-packages.sh@46 PS1, Line 46: version=$(test -x ./git-version-gen && ./git-version-gen . > .tarball-version 2>/dev/null) $version is now empty since > redirects the output.:w Maybe add a version=$(cat .tarball-version) here? https://gerrit.osmocom.org/#/c/10343/1/scripts/osmocom-nightly-packages.sh@51 PS1, Line 51: if [ -z "$version" ] ; then So this will always be true. -- To view, visit https://gerrit.osmocom.org/10343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76e3713f0b01a6110091ff90e8e53aa79533c374 Gerrit-Change-Number: 10343 Gerrit-PatchSet: 1 Gerrit-Owner: Harald Welte <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Mon, 06 Aug 2018 09:18:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
