Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10333 )
Change subject: GSCON: avoid sending connection oriented data when not connected ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/10333/2/src/osmo-bsc/osmo_bsc_sigtran.c File src/osmo-bsc/osmo_bsc_sigtran.c: https://gerrit.osmocom.org/#/c/10333/2/src/osmo-bsc/osmo_bsc_sigtran.c@354 PS2, Line 354: return -EINVAL; are we sure that msg doesn't need to be free'd here? It's typically good practise to write the msgb ownership aspects of a function in the comment (whether or not in doxygen format) on top of each function. Unfortunately this function doesn't have this, so we have to read more code... https://gerrit.osmocom.org/#/c/10333/2/src/osmo-bsc/osmo_bsc_sigtran.c@377 PS2, Line 377: return -EINVAL; we also appear to have another memory leak of msg here. https://gerrit.osmocom.org/#/c/10333/2/src/osmo-bsc/osmo_bsc_sigtran.c@387 PS2, Line 387: osmo_sccp_tx_data_msg this function will msgb_free() the msg, see the libosmo-sccp code. -- To view, visit https://gerrit.osmocom.org/10333 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4eaa983702224e5995a388ea9890ee04212eb569 Gerrit-Change-Number: 10333 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 06 Aug 2018 15:57:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
