Harald Welte has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10433 )

Change subject: layer23: Fix compiler warning about snprintf buffer too small
......................................................................

layer23: Fix compiler warning about snprintf buffer too small

gsm322.c:366:22: warning: ‘sprintf’ may write a terminating nul past the end of 
the destination [-Wformat-overflow=]
  sprintf(string, "-%d", 110 - rxlev);
                      ^
gsm322.c:366:2: note: ‘sprintf’ output between 3 and 6 bytes into a destination 
of size 5
  sprintf(string, "-%d", 110 - rxlev);

Change-Id: I7b19fef89ba0cb0c1edbdd62c46ad8395e44145b
---
M src/host/layer23/src/mobile/gsm322.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Vadim Yanitskiy: Looks good to me, but someone else must approve
  Jenkins Builder: Verified



diff --git a/src/host/layer23/src/mobile/gsm322.c 
b/src/host/layer23/src/mobile/gsm322.c
index 3bc8b5c..a2cbb86 100644
--- a/src/host/layer23/src/mobile/gsm322.c
+++ b/src/host/layer23/src/mobile/gsm322.c
@@ -358,7 +358,7 @@

 char *gsm_print_rxlev(uint8_t rxlev)
 {
-       static char string[5];
+       static char string[6];
        if (rxlev == 0)
                return "<=-110";
        if (rxlev >= 63)

--
To view, visit https://gerrit.osmocom.org/10433
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7b19fef89ba0cb0c1edbdd62c46ad8395e44145b
Gerrit-Change-Number: 10433
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>

Reply via email to