Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10442 )
Change subject: xua_msg: Avoid memleaking xua_msg_part in xua_msg_free ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10442/1/src/xua_msg.c File src/xua_msg.c: https://gerrit.osmocom.org/#/c/10442/1/src/xua_msg.c@59 PS1, Line 59: struct xua_msg_part *part, *tmp; why are we leaking parts As the xua_msg_part should all be allocated as children of the xua_msg, talloc should neatly clean all of the parts up. If you find parts that are allocated not as children of the xua_msg parent context, then I would think the bug is at that point. -- To view, visit https://gerrit.osmocom.org/10442 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9ca8aea50b3715890b9ea0290471e95caed4624 Gerrit-Change-Number: 10442 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Mon, 13 Aug 2018 16:19:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
