Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10162 )
Change subject: ipa_asp_fsm: init: expect IPA ID ACK, not GET ...................................................................... Patch Set 2: Code-Review+2 I'm not entirely happy about unconditionally merging this. I would suggest to review various pcap files of IPA establishment against different peer implementations and then try to understnd what's really the right thing to do. However, given that the IPA code in this specific implementation is currently not used at all, I'm happy to say "I don't care [yet]". -- To view, visit https://gerrit.osmocom.org/10162 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icffda98579e676ab6ca63c9c22cf5d151c4fe95f Gerrit-Change-Number: 10162 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 20 Aug 2018 20:29:54 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
