Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10685 )
Change subject: Always initialize the _started in the test ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10685/1/src/osmo_ms_driver/location_update_test.py File src/osmo_ms_driver/location_update_test.py: https://gerrit.osmocom.org/#/c/10685/1/src/osmo_ms_driver/location_update_test.py@86 PS1, Line 86: self._started = [] Maybe more clean to have it more at the start of the __init__ function together with other var initialization. -- To view, visit https://gerrit.osmocom.org/10685 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I675772c89e32620da5695aa4793b735cc266684c Gerrit-Change-Number: 10685 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 29 Aug 2018 10:56:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
