Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10686 )
Change subject: Create a "ms_driver" stub for the testsuite ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py File src/osmo_gsm_tester/ms_driver.py: https://gerrit.osmocom.org/#/c/10686/1/src/osmo_gsm_tester/ms_driver.py@105 PS1, Line 105: self._test_case.run_test(self._loop, self._test_duration) > Not sure right now how the SimpleLoop integrates with osmo-gsm-tester > event_loop.py:EventLoop. […] Ok, looking at the code it seems you implement your own select here. That's not going to work nice with osmo-gsm-tester, since EventLoop is used to manage/handle events for other object types, like osmo-* slave processes being launched and see if they exited prematurely, dbus messages with dbus, smpp socket fd handling, etc. So you should move your code to use EventLoop. It seems rgistering an FD to poll is not there supported in EventLoop rigth waya, but it should be easy to add by adding a new Glib.Source subclass in event_loop.py as explained in [1] then add APIs "(un)register_poll_fd" to EventLoop which uses those. [1] https://blogs.gnome.org/desrt/2012/05/09/glib-mainloop-sources-in-python-e-g-for-irclib/ Also related: https://osmocom.org/issues/2512 https://osmocom.org/issues/3234 -- To view, visit https://gerrit.osmocom.org/10686 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I586b6d532c6e6395b4e6f2cf2128372237d05a7d Gerrit-Change-Number: 10686 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 29 Aug 2018 11:36:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
