Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/10687 )
Change subject: Add an initial test for the ms_driver ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/10687/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/10687/1//COMMIT_MSG@11 PS1, Line 11: * Should modems==0 be allowed to be set? It should be allowed for sure. You are not actually using a "modem" resource yet anyway, since afaiu the modems are still started manually at this current status. Even when you start the several mobile applications with virtphy you may still run them without being allocated as "resources" since there may not be something unique you want to reserve (like a piece of HW). It may be the case that you need a different IP addr for each mobile (which means a lot of IP addr). In that case, since some time ago I have been willing to implement "dynamic resources", that is resources which are automatically generated and don't require to be specified in resources.conf. In the case of IP addresses, that would be for instance an IP addr pool which would dynamically provide with IP addresses and assign it it a given interface (eg lo or eth depending on needs). https://gerrit.osmocom.org/#/c/10687/1//COMMIT_MSG@12 PS1, Line 12: * I should compile/package the mobile and virtphy as well And osmo-bts-virtual in contrib/jenkins-build-osmo-bts.sh. iirc virtphy and mobile are both in osmocom-bb.git. You can add them in contrib/jenkins-build-osmocom-bb.sh. https://gerrit.osmocom.org/#/c/10687/1//COMMIT_MSG@13 PS1, Line 13: * When executing suites shall we have a way to select only the The only difference I foresee is basically making sure we match the type of interface we use to communicate between objects, that is: if we take real modems talking over the air, then we need a BTS which talks over the air. If modems selected go through virtphy, then BTS selected has to be through virtphy. This can be done through scenario files, not need to create a new suite for each virtual/non-virtual. See example/default-suites.conf to see different stuff we run nightly. For instance: voice:nanobts+band-900+mod-bts0-ts-tchh+cfg-codec-hr3 We take the voice suite (suites/voice/suite.conf), which requires 1 BTS and 2 modem. Then through scenarios we specify several stuff: * Select first BTS to be of type nanobts (scenarios/nanobts.conf) * Select first BTS to support at least band GSM-900 (and-900.conf) * Modify the first BTS to use TCH/H timeslots (mod-bts0-ts-tchh.conf) * Configure all BSC with "codec-list hr3" (cfg-codec-hr3.conf). So we can do something similar by: * resources.conf: Add a BTS-virtual with type:osmo-bts-virtual (class not implemented yet). * Then create a new band called virtphy: "band:virtphy" * If you want to reuse existing tests with mobile+virtphy, apart from implementing the ModemOsmoMobile class, then add a bands list to modem resource to speicify which bands supports. Then, to run the voice test with virtphy, you create scenarios something like: voice:nanobts+band-virtphy+modem-band-virtphy. BTW, Regarding the ARFCN resources you see in resources.conf, they are not still used correctly, as proper algorithm to select them is needed: https://osmocom.org/issues/2230 -- To view, visit https://gerrit.osmocom.org/10687 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5be2a6b4d3d21bf48625624b9e2cccb33765fe39 Gerrit-Change-Number: 10687 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 29 Aug 2018 12:03:47 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
