Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10701 )
Change subject: lchan: pick proper power and ta values ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/10701/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/10701/1//COMMIT_MSG@18 PS1, Line 18: For the power,TA levels, take over an old lchan's values only when it is : assigning a new lchan in the same cell. this doesn't make sense, sorry. The process of establishing the new radio channel in asynchronous hand-over with the RACH bursts exists exactly to determine the TA value of the new channel. Copying TA from the old lchan only makes sense if the old lchan is in the same *BTS*. A diferent BTS managed by the same BSC will normally be at a completely different geographical location and you cannot make any assumption on the TA. Hence the async hand-over.... regarding power levels, I would always start with the hghest power level possible/permitted. the power control loop will then ramp down to whatever is sufficient. -- To view, visit https://gerrit.osmocom.org/10701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I360b003398487fa6f934296ff03643c33ec61a35 Gerrit-Change-Number: 10701 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Thu, 30 Aug 2018 12:49:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
