Stefan Sperling has posted comments on this change. ( 
https://gerrit.osmocom.org/10414 )

Change subject: update DTX fill frame test expectations
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/10414/1/bts/BTS_Tests.ttcn
File bts/BTS_Tests.ttcn:

https://gerrit.osmocom.org/#/c/10414/1/bts/BTS_Tests.ttcn@3840
PS1, Line 3840:
> Should we merge this patch now? Does it reliably reproduce the above?

Yes, I think we should merge it. The first test keeps passing, the second test 
keeps failing.
So this change doesn't make things worse.

It is unclear when the second test will start passing. I have not been able to 
make it pass on my hardware setup so far (for unrelated reasons). A pass on 
jenkins will require DTX support in trxcon.



--
To view, visit https://gerrit.osmocom.org/10414
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie573b54ab5654f027c470aa7a565d2b5b97dc74b
Gerrit-Change-Number: 10414
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Comment-Date: Tue, 04 Sep 2018 10:06:02 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to