Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10760 )
Change subject: measurement: fix SACCH interval remapping in test_is_meas_overdue() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c File src/common/measurement.c: https://gerrit.osmocom.org/#/c/10760/1/src/common/measurement.c@316 PS1, Line 316: return fn - 26; as we discussed in person, it's actually rather 26*3 than 26. The result is simply the same in modulo arithmetic. Let's please add some related comments and re-write it with 26*3 as that's the difference between the first and the last SACCH burst in the 26-multiframe. -- To view, visit https://gerrit.osmocom.org/10760 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf6db73f67b7273c3d5965616c9e78f66b74a406 Gerrit-Change-Number: 10760 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 04 Sep 2018 17:28:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
