Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/10780 )

Change subject: Use uint8_t instead of int8_t for Timing Advance
......................................................................


Patch Set 1: Code-Review-1

I think the signed is intentional so you can spoof wrong locations


--
To view, visit https://gerrit.osmocom.org/10780
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2ffd24bfb5abb7cc03b20a99628ef18dd365c15
Gerrit-Change-Number: 10780
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Comment-Date: Wed, 05 Sep 2018 21:14:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to