Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/10773 )

Change subject: Fix "'laforge/debian-jessie-build' not found"
......................................................................


Patch Set 1: Code-Review+1

I think the commit log should mention where the $USER is coming from -- it's 
not directly from the env, but taking advantage of the fact that make/Makefile 
already feeds the env's $USER in as commandline build argument.

Otherwise very nice.


--
To view, visit https://gerrit.osmocom.org/10773
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5f11c8a4e247f632cb6aea6d147e94c53e0130f
Gerrit-Change-Number: 10773
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Thu, 06 Sep 2018 13:05:55 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to