Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/10782 )
Change subject: grgsm_trx: Migrated argument parsing to argparse ...................................................................... Patch Set 1: (4 comments) https://gerrit.osmocom.org/#/c/10782/1/apps/grgsm_trx File apps/grgsm_trx: https://gerrit.osmocom.org/#/c/10782/1/apps/grgsm_trx@a180 PS1, Line 180: Also, I guess this wouldn't work anymore... https://gerrit.osmocom.org/#/c/10782/1/apps/grgsm_trx@26 PS1, Line 26: import getopt This dependency is not required anymore. To have a cleaner change, I would place the import of argparse here. https://gerrit.osmocom.org/#/c/10782/1/apps/grgsm_trx@44 PS1, Line 44: class grgsm_trx: Changing the class name is not related to the argv handling. https://gerrit.osmocom.org/#/c/10782/1/apps/grgsm_trx@155 PS1, Line 155: app = grgsm_trx( I think we can pass the parsing result directly to the init function. -- To view, visit https://gerrit.osmocom.org/10782 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: gr-gsm Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf99fd7a581464aa2f77fe01e721dbd162686811 Gerrit-Change-Number: 10782 Gerrit-PatchSet: 1 Gerrit-Owner: Piotr Krysik <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 06 Sep 2018 13:25:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
