Neels Hofmeyr has submitted this change and it was merged. ( 
https://gerrit.osmocom.org/10810 )

Change subject: SCCPlite Assignment Complete: include Speech Codec (Chosen)
......................................................................

SCCPlite Assignment Complete: include Speech Codec (Chosen)

Compose the Speech Codec (Chosen) IE not only for AoIP, but also for SCCPlite:
place the code that assigns the codec to sc_ptr outside of the gscon_is_aoip()
if scope.

This way the MSC is told the chosen speech codec, which is mandatory for IP
based user plane, and was missing until now.

Related: OS#3528
Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1
---
M src/osmo-bsc/assignment_fsm.c
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  Harald Welte: Looks good to me, approved



diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c
index e1da45b..63776f0 100644
--- a/src/osmo-bsc/assignment_fsm.c
+++ b/src/osmo-bsc/assignment_fsm.c
@@ -163,12 +163,12 @@
                                return;
                        }
                        addr_local_p = &addr_local;
-
-                       /* Extrapolate speech codec from speech mode */
-                       gsm0808_speech_codec_from_chan_type(&sc, perm_spch);
-                       sc_ptr = ≻
                }
+
+               /* Extrapolate speech codec from speech mode */
                /* FIXME: AMR codec configuration must be derived from lchan1! 
*/
+               gsm0808_speech_codec_from_chan_type(&sc, perm_spch);
+               sc_ptr = ≻
        }

        resp = gsm0808_create_ass_compl(lchan->abis_ip.ass_compl.rr_cause,

--
To view, visit https://gerrit.osmocom.org/10810
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibedade8d71a7994d25a63bc2faa2a24a10bfffa1
Gerrit-Change-Number: 10810
Gerrit-PatchSet: 2
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>

Reply via email to