Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/10808 )
Change subject: add vty config for GSMTAP-SAPI remote host (-i) ...................................................................... Patch Set 2: > So that is a bug, then? Is it really harmful to do name resolution > once at program startup? Once at program startup is acceptable, like in the case of a command-line argument which cannot change at runtime. But it's not accceptable if we do a blocking DNS lookup at some later runtime of the program, if the user changes it via VTY. So in thaat case, we must restrict it in some way to use only IP addresses. -- To view, visit https://gerrit.osmocom.org/10808 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17676a21c4e0c9cbc88f2c5c53a39c6c6c473ca1 Gerrit-Change-Number: 10808 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 11 Sep 2018 03:26:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
