Holger Freyther has posted comments on this change. ( https://gerrit.osmocom.org/10967 )
Change subject: Install to /bin as it doesn't require special privileges.. ...................................................................... Patch Set 2: > I think since we don't plan to have binaries with spaces in path is > not worth spending time changing the logic in the osmo-gsm-tester > script. This patch is good though. Well. Either way it is the wrong place and too late to have this discussion. My personal preference is to find robust solutions and spaces in shell scripts is a bug class that keeps on giving. I think it is better to not have to worry about a class of problems than excluding them it by decree. In a parallel universe where time is a less scarce resource... I would make these bash scripts, use arrays and have a way to disambiguate bin/foo and sbin/foo.. Other sbin binaries: I think we won't find many. wget --no-parent -r http://download.opensuse.org/repositories/network:/osmocom:/latest/Debian_9.0/amd64/ for i in `ls download.opensuse.org/repositories/network\:/osmocom\:/latest/Debian_9.0/amd64/*.deb`; do dpkg -c $i | grep sbin; done returns no hit. -- To view, visit https://gerrit.osmocom.org/10967 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibe572a4c17871785b623e70acc7f5da056f945e5 Gerrit-Change-Number: 10967 Gerrit-PatchSet: 2 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 18 Sep 2018 06:52:49 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
