Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/10932 )
Change subject: osmo-depcheck: script to verify PKG_CHECK_MODULES ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py File scripts/osmo-depcheck/buildstack.py: https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/buildstack.py@97 PS2, Line 97: old = os.environ[env_var] if env_var in os.environ else "" > Nice trick, but that seems to be a bit over-engineered here IMHO. ":path" > will work just as well. hmm, really, ":/path" is allowed? but it looks unhappy. I don't think it's overengineered, but whatever, nm https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py File scripts/osmo-depcheck/config.py: https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/config.py@18 PS2, Line 18: # they are mentioned with PKG_CHECK_MODULES in configure.ac. > Good point with the tuples. […] not important. https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/dependencies.py File scripts/osmo-depcheck/dependencies.py: https://gerrit.osmocom.org/#/c/10932/2/scripts/osmo-depcheck/dependencies.py@20 PS2, Line 20: # Clone when needed > Well, this is a pretty short function (14 LOC), and it does have a few key > differences: […] not that important, keep it -- To view, visit https://gerrit.osmocom.org/10932 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f495dbe030775f66ac125e60ded95c5d7660b65 Gerrit-Change-Number: 10932 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 15:20:15 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
