Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11048 )
Change subject: check for overlong unix socket paths ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp File src/osmobts_sock.cpp: https://gerrit.osmocom.org/#/c/11048/1/src/osmobts_sock.cpp@268 PS1, Line 268: if (osmo_strlcpy(local.sun_path, bts->pcu_sock_path, sizeof(local.sun_path)) >= sizeof(local.sun_path)) { I would prefer to see: rc = osmo_strlcpy(...); if (rc) { ... } here instead of this long construction. -- To view, visit https://gerrit.osmocom.org/11048 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825190cbb34d052b797e9fb5208884d6f5992839 Gerrit-Change-Number: 11048 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 20 Sep 2018 17:25:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
