Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11060 )
Change subject: codec_pref: handle S0-S15 in ASSIGNMENT REQUEST ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11060/5/src/osmo-bsc/handover_fsm.c File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/#/c/11060/5/src/osmo-bsc/handover_fsm.c@565 PS5, Line 565: /* FIXME: use the value in s15_s0 that has been computed by I think it's best to fix this right now to avoid forgetting about it later on. Isn't it basically simply setting the resulting bits in the lchan that is selected below (IF it is an AMR codec type)? If you really don't want to fix this here, I suggest to at least open an issue on osmocom.org and changing this FIXME in to a #warning or related pragma... -- To view, visit https://gerrit.osmocom.org/11060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d8ded51b3eb4c003fe2da6f2d6f48d001b73737 Gerrit-Change-Number: 11060 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Comment-Date: Mon, 24 Sep 2018 11:14:28 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
