Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11143 )
Change subject: exit if xterm was not found ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11143/4/net/tmpl_std/run.sh File net/tmpl_std/run.sh: https://gerrit.osmocom.org/#/c/11143/4/net/tmpl_std/run.sh@45 PS4, Line 45: exit 1 no, wait, we invoke term() only after starting the tcpdumps, so we should check terminal presence outside of term(), before invoking tcpdump. -- To view, visit https://gerrit.osmocom.org/11143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie823e17ff1e7ad3ba23998233b41a810c90858b3 Gerrit-Change-Number: 11143 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Assignee: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 11 Oct 2018 12:26:54 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
