osmith has posted comments on this change. ( https://gerrit.osmocom.org/11144 )
Change subject: support osmo-sip-connector with kamailio ...................................................................... Patch Set 6: (2 comments) https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh File net/tmpl_std/run.sh: https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh@79 PS6, Line 79: kamailio="$(sudo which kamailio)" > oof, ok ... maybe instead we should include /sbin or something in the $PATH? > […] Done https://gerrit.osmocom.org/#/c/11144/6/net/tmpl_std/run.sh@88 PS6, Line 88: sudo mkdir -p /var/run/kamailio > can we instead keep the kamailio run dir as a local subdir? Is it not > configurable in kamailio.cfg? […] Turns out, it is configurable as "rundir" in the config. I've set it to "/tmp/kamailio_rundir" now, and kamailio creates that folder and is happy with it. It would of course be better to not use /tmp for this either (or to have random names and clean it up properly). But then again we would need to change that for the socket path too, so I think it is good enough for now. Maybe at a later point we could add a well defined temporary directory to the script, which can be used with a variable in the configs. Your thoughts on sudo sound good to me. -- To view, visit https://gerrit.osmocom.org/11144 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5c4e9992eab390bc6d26ada7564223ff41a01b2 Gerrit-Change-Number: 11144 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Assignee: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Fri, 12 Oct 2018 11:46:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
