Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11386 )
Change subject: bssap: check for zero length speech codec lists. ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11386/1/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: https://gerrit.osmocom.org/#/c/11386/1/src/osmo-bsc/osmo_bsc_bssap.c@700 PS1, Line 700: if (conn->codec_list.len <= 0) { > This check is already done in line 708, and IMHO cause is better set there. > […] the difference is that the check here only applies *if* a SCL IE is actually present. So we fail/reject if an IE is present, but it is of zero length. where the "line 708" catches even situations where the IE wouldn't be preseng, but only if aoip is enabled? But then, how can we check for the length of an IE if it had never occurred? This looks a bit fishy? -- To view, visit https://gerrit.osmocom.org/11386 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2aca205dfdf5c7de7cb48ea2b57eb54e678e12fc Gerrit-Change-Number: 11386 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Tue, 16 Oct 2018 20:02:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
