dexter has submitted this change and it was merged. (
https://gerrit.osmocom.org/11387 )
Change subject: gsm_08_08: allow zero length speech codec lists in compl l3
info.
......................................................................
gsm_08_08: allow zero length speech codec lists in compl l3 info.
The COMPLETE LAYER 3 INFORMATION message contains a an Codec List (BSS
Supported). When generating the compl l3 info msg, we check if the
speech codec list that we have generated before has at least one
element. If it has 0 elements we abort immediately. However, speech
codec lists with 0 elements are permitted by the spec, so we should
remove the checks as there are corner cases where voice support is
intentionally unavailable.
- Remove check for zero length speech codec lists.
Change-Id: Id7332e5273ff0efb85043dd1e1bb804cfe2db944
Depends: libosmocore I1eb1f4466b98bdd26d765b0e4cc690b5e89e9dd6
Related: OS#3657
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, but someone else must approve
Harald Welte: Looks good to me, approved
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 6e1e502..807eb8c 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -495,12 +495,7 @@
if (gscon_is_aoip(conn)) {
gen_bss_supported_codec_list(&scl, msc, conn_get_bts(conn));
- if (scl.len > 0)
- resp = gsm0808_create_layer3_2(msg,
cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)), &scl);
- else {
- LOGP(DMSC, LOGL_ERROR, "Failed to create layer3 message
due to empty speech codec list.\n");
- return false;
- }
+ resp = gsm0808_create_layer3_2(msg, cgi_for_msc(conn->sccp.msc,
conn_get_bts(conn)), &scl);
} else
resp = gsm0808_create_layer3_2(msg, cgi_for_msc(conn->sccp.msc,
conn_get_bts(conn)), NULL);
--
To view, visit https://gerrit.osmocom.org/11387
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id7332e5273ff0efb85043dd1e1bb804cfe2db944
Gerrit-Change-Number: 11387
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
