Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11420 )
Change subject: bssmap_handle_cipher_mode(): Don't sent reject if !conn
......................................................................
bssmap_handle_cipher_mode(): Don't sent reject if !conn
We can only send a reject response if we have a valid conn.
Change-Id: I0ea535f494173ad4996c70dc82d7f69455e4e15e
Fixes: Coverity CID#188824
---
M src/osmo-bsc/osmo_bsc_bssap.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/osmo_bsc_bssap.c b/src/osmo-bsc/osmo_bsc_bssap.c
index 537b851..a20d5d0 100644
--- a/src/osmo-bsc/osmo_bsc_bssap.c
+++ b/src/osmo-bsc/osmo_bsc_bssap.c
@@ -439,7 +439,7 @@
if (!conn) {
LOGP(DMSC, LOGL_ERROR, "No lchan/msc_data in cipher mode
command.\n");
- goto reject;
+ return -1;
}
if (conn->ciphering_handled) {
--
To view, visit https://gerrit.osmocom.org/11420
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0ea535f494173ad4996c70dc82d7f69455e4e15e
Gerrit-Change-Number: 11420
Gerrit-PatchSet: 3
Gerrit-Owner: Harald Welte <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
