Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11390 )
Change subject: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/11390/1/Transceiver52M/sigProcLib.cpp File Transceiver52M/sigProcLib.cpp: https://gerrit.osmocom.org/#/c/11390/1/Transceiver52M/sigProcLib.cpp@1615 PS1, Line 1615: sync = gRACHSequences[i]; this will have a signifinant impact on performance, at last that's what I would expect. There's now three rather long correclations for the short RACH burst, rather than one. I guess this requires some benchmarks/comparisons and should then possibly have some flag/switch whether or not we really want to enable it. After all, there's no point in paying the performance penalty unless upper levels (BTS, PCU) actually make use of it. -- To view, visit https://gerrit.osmocom.org/11390 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I838c21db29c54f1924dd478c2b34b46b70aab2cd Gerrit-Change-Number: 11390 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Assignee: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Tom Tsou <[email protected]> Gerrit-Comment-Date: Sun, 21 Oct 2018 12:24:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
