Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11428 )
Change subject: bts: Disable testing FACCH/H with real HW ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/#/c/11428/2/bts/BTS_Tests.ttcn@336 PS2, Line 336: }; rather than copy+pasting the entire array, one could probably have simply used the "append" operator (&) to add the one additional element in case mp_bb_trxc_port==-1. But well, not critical. -- To view, visit https://gerrit.osmocom.org/11428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I078cdfbf8d27e543a723eab90f66b2fcda016b5d Gerrit-Change-Number: 11428 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 22 Oct 2018 20:19:56 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
