Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11429 )

Change subject: RSL_Emulation: handle ASP_IPA_EVENT_DOWN
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11429/2//COMMIT_MSG@9
PS2, Line 9: Otherwise RSL layer fails this way when this event is received:
Why are we expecting the RSL layer to ever receive an ASP_IPA_EVENT_DOWN?  I 
agree the message is a bit cryptic, but I'm not sure if it is the right 
approach to simply ignore it.  Rather than ignoring, we could explicitly 
fail/stop?



--
To view, visit https://gerrit.osmocom.org/11429
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc6565c9de72d98015d56a41e5616c46051c8a8d
Gerrit-Change-Number: 11429
Gerrit-PatchSet: 2
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-CC: Harald Welte <lafo...@gnumonks.org>
Gerrit-Comment-Date: Mon, 22 Oct 2018 20:21:31 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to