Vadim Yanitskiy has posted comments on this change. (
https://gerrit.osmocom.org/11446 )
Change subject: bts-trx: Try decoding received UL bursts when SACCH frame
detected as lost
......................................................................
Patch Set 1: Code-Review-1
It makes sense to investigate the problem carefully. I think, that
this change makes complicated things even more complex. Why?
- In general, SACCH frame loss detection is implemented in a
hackish way ATM - it's being triggered by DL processing path,
which is not (and should not be) synchronized with the UL
processing path. We have at least ~20 TDMA frame difference
between them. See both 'osmotrx fn-advance' and 'osmotrx rts-advance'
configuration options for OsmoBTS, and '-f --trx-advance' command
line option for trxcon.
- Instead of complicating the code more, I think we should focus on
implementing (and discussing) the TDMA frame loss detection on the
link between L1 and TRX.
--
To view, visit https://gerrit.osmocom.org/11446
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I910277df181df5082b234c1c97a75eebdffc2cb5
Gerrit-Change-Number: 11446
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Comment-Date: Wed, 24 Oct 2018 13:32:58 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
