Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11437 )

Change subject: cosmetic: fix spec ref for gsm0808_cipher_mode()
......................................................................


Patch Set 1:

> What am I missing?

That this code has nothing to do with the 04.08 (Mobile Layer 3), but with 
BSSAP/BSSMAP specified in 08.08.

It's nice that some other spec also mentions something about what that layer of 
the stack / that interface has to do in case of a cipher mode set.  But that 
still doesn't make it apply here.  You have to find the related section in 
08.08 (or these days, 48.008).


--
To view, visit https://gerrit.osmocom.org/11437
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I359caf1dd30f033c0b606040ccf27aa4c5a9d2c6
Gerrit-Change-Number: 11437
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Comment-Date: Wed, 24 Oct 2018 18:49:53 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to