Harald Welte has posted comments on this change. ( 
https://gerrit.osmocom.org/11439 )

Change subject: use a dynamic name for rtp connection rate counters
......................................................................


Patch Set 1: Code-Review-1

this is not really how rate counter groups were intended to be used.  The point 
is that you have one const group descriptor, and then multiple rate counter 
groups allocated from that descriptor.  If thre's a problem with displaying the 
counters, then that needs to be solved on an infrastructure level, and not by 
"hacking" around with a copy of the group descriptor, sorry.


--
To view, visit https://gerrit.osmocom.org/11439
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I027644f4b913e1f966c11b081e9027e61591a224
Gerrit-Change-Number: 11439
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de>
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Oct 2018 17:49:44 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes

Reply via email to