Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/11457 )

Change subject: mobile: fix vty bind ip override
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11457/1/src/host/layer23/src/mobile/main.c
File src/host/layer23/src/mobile/main.c:

https://gerrit.osmocom.org/#/c/11457/1/src/host/layer23/src/mobile/main.c@254
PS1, Line 254: use_custom_vty_ip
You could just check 'vty_ip' against NULL. There is no need
to introduce additional 'use_custom_vty_ip'...



-- 
To view, visit https://gerrit.osmocom.org/11457
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32517567847fd5c54b1742f18bf409ff81e316fa
Gerrit-Change-Number: 11457
Gerrit-PatchSet: 1
Gerrit-Owner: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-Comment-Date: Fri, 26 Oct 2018 08:50:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to