osmith has posted comments on this change. ( https://gerrit.osmocom.org/11493 )
Change subject: vty: add 'show rejected-bts' ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/11493/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/11493/3/include/osmocom/bsc/gsm_data.h@1139 PS3, Line 1139: char ip[64]; > You can use the ADDRLEN6LEN or however it's called here. Done https://gerrit.osmocom.org/#/c/11493/1/src/osmo-bsc/bts_ipaccess_nanobts.c File src/osmo-bsc/bts_ipaccess_nanobts.c: https://gerrit.osmocom.org/#/c/11493/1/src/osmo-bsc/bts_ipaccess_nanobts.c@475 PS1, Line 475: _i > Please, do send patches for stuff which you think require fixes, then we can > discuss them separately […] Done: https://gerrit.osmocom.org/#/c/libosmocore/+/11520/ -- To view, visit https://gerrit.osmocom.org/11493 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba3bfe8fc9432b7ae8f819df8bd71b35b3ec507e Gerrit-Change-Number: 11493 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Oct 2018 13:57:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No