Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11527 )
Change subject: gsm_data: make cgi_for_msc available for other modules ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11527/1/src/osmo-bsc/gsm_data.c File src/osmo-bsc/gsm_data.c: https://gerrit.osmocom.org/#/c/11527/1/src/osmo-bsc/gsm_data.c@1690 PS1, Line 1690: if (!msc) Better break changes & movements in separate patches. Moreover, do we really want to allow to pass NULL MSC or BSC? I'd remove those. -- To view, visit https://gerrit.osmocom.org/11527 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I301fac6e83a429ae59b5c586aa283ad7ba54053d Gerrit-Change-Number: 11527 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 30 Oct 2018 16:39:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
