Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11569 )
Change subject: Properly parse cause in cipher mode reject ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11569/1/src/libmsc/a_iface_bssap.c File src/libmsc/a_iface_bssap.c: https://gerrit.osmocom.org/#/c/11569/1/src/libmsc/a_iface_bssap.c@436 PS1, Line 436: cause = (enum gsm0808_cause)TLVP_VAL(tp, GSM0808_IE_CAUSE); Doesn't TLVP_VAL return a pointer to the data? You should take the pointer, then load 1 or 2 bytes from there depending on bit 8 from fist data octet. -- To view, visit https://gerrit.osmocom.org/11569 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I26b3eb0deff6dbd217b23d284bbc6e6a9eebc8e6 Gerrit-Change-Number: 11569 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 02 Nov 2018 09:25:34 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
