Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11550 )
Change subject: RSL: restructure MDCX functions ...................................................................... Patch Set 3: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/11550/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11550/3//COMMIT_MSG@12 PS3, Line 12: * make IP address helper accessible via header file why? I see no-one using it outside of the static context https://gerrit.osmocom.org/#/c/11550/3//COMMIT_MSG@14 PS3, Line 14: * constify rsl_tx_ipacc_*cx() parameters this lists three changes that seem unrelated and should hence be in separate, smaller patches. https://gerrit.osmocom.org/#/c/11550/3/include/osmocom/bsc/abis_rsl.h File include/osmocom/bsc/abis_rsl.h: https://gerrit.osmocom.org/#/c/11550/3/include/osmocom/bsc/abis_rsl.h@64 PS3, Line 64: struct msgb *rsl_make_ipacc_mdcx(const struct gsm_lchan *lchan, uint32_t dest_ip, uint16_t dest_port); At least mention in the commit log in which other commit this will be used; but I'd prefer squashing with the actual caller that needs this change. (that would also have answered Pau's question, most likely) https://gerrit.osmocom.org/#/c/11550/3/src/osmo-bsc/abis_rsl.c File src/osmo-bsc/abis_rsl.c: https://gerrit.osmocom.org/#/c/11550/3/src/osmo-bsc/abis_rsl.c@1873 PS3, Line 1873: rather omit whitespace change https://gerrit.osmocom.org/#/c/11550/3/src/osmo-bsc/abis_rsl.c@1876 PS3, Line 1876: rather omit whitespace change -- To view, visit https://gerrit.osmocom.org/11550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iffe2f4f10e841fc36965cce02b4e5f017a5ae6c8 Gerrit-Change-Number: 11550 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 02:51:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
