Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11551 )
Change subject: LCLS: move mode check into separate function ...................................................................... Patch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11551/3/src/osmo-bsc/osmo_bsc_lcls.c File src/osmo-bsc/osmo_bsc_lcls.c: https://gerrit.osmocom.org/#/c/11551/3/src/osmo-bsc/osmo_bsc_lcls.c@230 PS3, Line 230: static inline bool lcls_check_toggle_ok(const struct gsm_subscriber_connection *conn, bool enable) heh, the function name ... maybe just lcls_toggle_allowed()? https://gerrit.osmocom.org/#/c/11551/3/src/osmo-bsc/osmo_bsc_lcls.c@233 PS3, Line 233: conn->sccp.msc->lcls_mode != conn->lcls.other->sccp.msc->lcls_mode) { If I want to break a loop, it doesn't make sense to check for a mode mismatch, does it? It seems to me that this first part should not be in the common function, but rather only in lcls_locally_switched_onenter()? ... or maybe skip this if enable == false? -- To view, visit https://gerrit.osmocom.org/11551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32ba232ad802625d97a0ad9d0511edc6ac7f251c Gerrit-Change-Number: 11551 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 03:10:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
