Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11597 )
Change subject: ms_driver: Switch to process.Process from subprocess ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/11597/1/src/osmo_ms_driver/starter.py File src/osmo_ms_driver/starter.py: https://gerrit.osmocom.org/#/c/11597/1/src/osmo_ms_driver/starter.py@56 PS1, Line 56: self._vphy_proc.launch() You are missing before launch: self.suite_run.remember_to_stop(self._vphy_proc) https://gerrit.osmocom.org/#/c/11597/1/src/osmo_ms_driver/starter.py@125 PS1, Line 125: self._omob_proc.launch() You are missing before launch: self.suite_run.remember_to_stop(self._omob_proc) -- To view, visit https://gerrit.osmocom.org/11597 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d4e161ac4283a63ed4e0745b375e7e6a25004 Gerrit-Change-Number: 11597 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 09:57:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
