Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11559 )
Change subject: BSC LCLS: add bts-loop tests ...................................................................... Patch Set 3: (5 comments) https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests.ttcn@a292 PS3, Line 292: Why not to expose this function in a separate change? https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests_LCLS.ttcn File bsc/BSC_Tests_LCLS.ttcn: https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests_LCLS.ttcn@239 PS3, Line 239: f_init_vty(); cosmetic: this could be placed outside the 'if' statement. https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests_LCLS.ttcn@295 PS3, Line 295: chan_nr := ie.chan_nr Hmm, missing semicolon? I think the build verification would fail... Probably, it works when a { ... } block contains only a single line, but adding a new line would require one to add the missing semicolon. Let's avoid this. https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests_LCLS.ttcn@297 PS3, Line 297: log("Unable to find chan# in ", rsl_msg) Same here. And moreover, should we just ignore this? Wouldn't this cause dynamic testcase error? https://gerrit.osmocom.org/#/c/11559/3/bsc/BSC_Tests_LCLS.ttcn@334 PS3, Line 334: CONN_A.receive(RSL_Message:?) -> value rsl_msg Why this part is commented out? Makes sense to add some FIXME/TODO note. -- To view, visit https://gerrit.osmocom.org/11559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40e786b430591899c722d99d685db26efa868508 Gerrit-Change-Number: 11559 Gerrit-PatchSet: 3 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 05 Nov 2018 22:55:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
