Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/5753 )
Change subject: LC15: Fix missing fill frame and GSM 05.08 mandatory frame ...................................................................... Patch Set 9: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/5753/9/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: https://gerrit.osmocom.org/#/c/5753/9/src/osmo-bts-litecell15/l1_if.c@365 PS9, Line 365: LOGP(DL1C, LOGL_DEBUG, "%s tn=%u: Sending fill frame on in none DTX mode " This text keeps being really confusing and needs fixing. First, we don't send any fill frame here, we only create and fill the message. Second: "on in none DTX mode" makes no sense to me. -- To view, visit https://gerrit.osmocom.org/5753 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I40e9bf9438c0b400e4d29eb39ffae37207e34db6 Gerrit-Change-Number: 5753 Gerrit-PatchSet: 9 Gerrit-Owner: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Minh-Quang Nguyen <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 12:21:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
