Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11632 )
Change subject: prevent potential NULL dereference in virtbts's tx_tchh_fn ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/11632/1/src/osmo-bts-virtual/scheduler_virtbts.c File src/osmo-bts-virtual/scheduler_virtbts.c: https://gerrit.osmocom.org/#/c/11632/1/src/osmo-bts-virtual/scheduler_virtbts.c@463 PS1, Line 463: if (msg_facch) { IIUC, whe chan_state->dl_ongoing_facch is TRUE, that means msg_facch cannot be NULL (unless something really bad is going on), and as a result we always go into this branch. Can tx_tch_common return msg_facch==NULL and msg_tch==NULL at the same time? -- To view, visit https://gerrit.osmocom.org/11632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf5584396c5b925d55ca9380dd4f869ae5d72da3 Gerrit-Change-Number: 11632 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 06 Nov 2018 15:36:41 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
